Save the transcript of a recording without speech too, so the file that the log reports and the editor opens exists - #356
Open
happyarts wants to merge 1 commit into
Conversation
…at the log reports and the editor opens exists The transcript was written only once the first segment arrived. When Whisper returned none -- silence, music, a recording that is too quiet -- the log still said the transcript was saved and linked it, and for a single html job the editor was opened on a file that did not exist. A transcription that succeeded now saves the header all the same; one that failed still writes nothing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The transcript file is written once the first segment arrives. When Whisper returns none (silence, music, a recording that is too quiet), nothing is written. The log still says "Saved to: …" with a link, the CLI prints "Output saved to …" and exits 0, and for a single html job the editor is opened on a file that does not exist.
A transcription that succeeded now saves the document even without segments: the title and header with the options, like any other transcript. A transcription that failed still writes nothing.
tests/test_empty_transcript.pyrunsHeadlessApp._process_single_jobon a silent WAV with the Whisper worker stubbed: once returning no segments (the transcript must exist and hold the header), once raising (no file). Also checked end to end with the real Whisper worker on 10 s of silence: before, "Output saved to" and no file; now a 1.3 KB transcript.🤖 Generated with Claude Code