build(jsonschema): build the schema generator in a go workspace - #471
Merged
Merged
Conversation
internal/jsonschema depends on the parent rig module through a local replace, so its indirect requirements have to match whatever the root go.mod requires. Every dependency bump in the root module leaves them stale and the go command then refuses to build here with "updates to go.mod needed" until this module is tidied as well. Dependabot never does that, so all of its pull requests fail schema-validation. Add a go.work that covers the schema module and the repository root so the build list is computed across both, and ignore the generated go.work.sum - the per-module go.sum files already cover every selected version. The workspace file lives in internal/jsonschema so that root module commands keep running in plain module mode. Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
internal/jsonschema depends on the parent rig module through a local replace, so its indirect requirements have to match whatever the root go.mod requires. Every dependency bump in the root module leaves them stale and the go command then refuses to build here with "updates to go.mod needed" until this module is tidied as well. Dependabot never does that, so all of its pull requests fail schema-validation.
Add a go.work that covers the schema module and the repository root so the build list is computed across both, and ignore the generated go.work.sum - the per-module go.sum files already cover every selected version. The workspace file lives in internal/jsonschema so that root module commands keep running in plain module mode.