added boolinq::mut_from and modified for each to be able to mutate#67
Open
LennardR wants to merge 2 commits into
Open
added boolinq::mut_from and modified for each to be able to mutate#67LennardR wants to merge 2 commits into
LennardR wants to merge 2 commits into
Conversation
Owner
|
@LennardR could you restore updated formatting to keep changes more focused? |
Author
|
Yeah, don't know how that happend. |
k06a
reviewed
Feb 3, 2022
| // | ||
|
|
||
| struct LinqEndException {}; | ||
| struct LinqNonMutableException {}; |
Owner
There was a problem hiding this comment.
Why can't utilize the same LinqEndException exception for this mutable case?
Author
There was a problem hiding this comment.
You can utilize the same exception. You can remove the LinqNonMutableException completely.
But for Debugging and using the Lib I think it is cleaner to have a dedicated Exception.
Owner
|
I see compilation error on GCC and Clang is that you use function template param T while the class has same template name T: https://app.travis-ci.com/github/k06a/boolinq/jobs/558567721#L631-L641 Try to rename the template parameter name to something else. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently compiles only with MSVC!
Propeses a Solution for #55 by introducing a mut_from function.
To enable the normal from function to be able to create mutable Linq Objects would require extensive reworking of existing code.