handle duplicate shared strings - #437
Open
davidskelly wants to merge 1 commit into
Open
davidskelly wants to merge 1 commit into
davidskelly wants to merge 1 commit into
Conversation
|
Can we get an ETA on this? @justkawal @justraman |
|
Please @justkawal @justraman give at least a feedback that you received the request. |
|
It works for me. |
|
@davidskelly I created a fork of Flutter Excel. The name is excel_community you can find it here link |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to read an excel file not created by me, sharedString is null.
This appears to be the case when xl/sharedStrings.xml contains duplicate entries, eg
A code change like
value = sharedString == null ? null : TextCellValue.span(sharedString!.textSpan);allows the document to parse, but now fetching certain cells point to the incorrect index and will return the wrong text - basically a corrupted document. So this is not the correct fix.When adding a shared string, adding it to the
_listalways, even if it's a duplicate, fixes the null pointer exception and fixes the text retrieval of the cells that were retrieving incorrect text values before.Same as this issue: #435 #433
Related to these prs: #434 #436