Skip to content

[Feature] Added comments extraction from referenced excel sheet and sheet visibility - #388

Open
rejero wants to merge 10 commits into
justkawal:mainfrom
rejero:main
Open

rejero wants to merge 10 commits into
justkawal:mainfrom
rejero:main

Conversation

@rejero

@rejero rejero commented Dec 6, 2024 •

Copy link
Copy Markdown

Linked Issues

Fix #232
Fix #241

Key Features:

  • Added functionality to retrieve cell comments from an excel file.
  • Added unit tests for a sample excel with different comment conditions.
  • Added method to obtain a sheet's visibility

Example Usage:

/*
 * To access comments, simply assign a Data? object to a variable and access the comment
 * 
 * @Return: String?
 * @Desc: cell's comment
*/
Data? cell
String? cellComment = cell.comment; // Returns null if no comments are available


/*
 * To access sheet visibility
 * @Return: Map<String, String>
 * @Desc: map of sheet names and their visibility status
*/
Excel excel
excel.getSheetVisibility();

Future Work:

Additional work to be done is to retrieve the comment's text styling as well, instead of a simple String.
More work can be done to test for any breaking conditions.

@rejero
rejero requested a review from justkawal as a code owner December 6, 2024 09:39
@rejero rejero changed the title [Feature] Added comments extraction from referenced excel sheet Resolves #232: [Feature] Added comments extraction from referenced excel sheet Dec 7, 2024
@rejero rejero changed the title Resolves #232: [Feature] Added comments extraction from referenced excel sheet [Feature] Added comments extraction from referenced excel sheet Dec 7, 2024
@rejero

rejero commented Dec 7, 2024

Copy link
Copy Markdown
Author

Resolves #232

@rejero

rejero commented Dec 17, 2024

Copy link
Copy Markdown
Author

Added an additional commit that provides the visibility of sheets via excel.getSheetVisibility()
Resolves #241

@rejero rejero changed the title [Feature] Added comments extraction from referenced excel sheet [Feature] Added comments extraction from referenced excel sheet and sheet visibility Dec 26, 2024
@rejero

rejero commented Apr 2, 2025

Copy link
Copy Markdown
Author

@justkawal Fixed merge conflicts

@rejero rejero left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed merge conflicts. Please review and decide if to merge with main

@rejero
rejero requested a review from justraman as a code owner June 28, 2025 03:47
@rejero rejero closed this Jan 26, 2026
@rejero rejero reopened this Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to read whether the worksheet is hidden or displayed [Feature] Add support for reading cell comments

1 participant