Repository navigation
Override all Number properties - #140
Conversation
alesstimec
left a comment
alesstimec
left a comment
There was a problem hiding this comment.
excuse my ignorance, but what's with all the seemingly random formatting changes (comments removed, comments added, new lines removed, new lines added).. it makes it very hard to review this PR as there seem to be loads of unrelated changes.
Juju 4 dropped descriptions from the facade methods so I made a change to remove the empty comment blocks. Something I did must have introduced another issue to add some blank lines. I'll take a look. |
50f18f4 to
7436b20
Compare
|
I've addressed the issue with the new blank lines. However there are still a lot of changes from regenerating the facades. |
Ninfa-Jeon
left a comment
Ninfa-Jeon
left a comment
There was a problem hiding this comment.
All good. One question and one correction.
| const valueType = extractType(patternProperty); | ||
| const valueType = extractType({ | ||
| ...patternProperty, | ||
| // Use the type that was extract above in case a ref was substituted with a primitive type. |
There was a problem hiding this comment.
| // Use the type that was extract above in case a ref was substituted with a primitive type. | |
| // Use the type that was extracted above in case a ref was substituted with a primitive type. |
3 participants
Done
The
Numbertype in the Juju schema is actually a string (see: https://bugs.launchpad.net/juju/+bug/2025108). Previously we had an override for theagent-versionfields, but this PR overrides the property anywhere that aNumberis referenced.All facades have been regenerated, and Juju 4.0.10 has been added.
The relevant changes are in this commit: 8584b37 and the second commit only contains the changes from running the
regenerate-all-facadesscript.