Skip to content

Fix build failure from stale .docker-image stamp #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jordanhubbard wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix build failure from stale .docker-image stamp #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions GNUmakefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,6 +436,18 @@ cleanall: clean
# ── Docker image (rebuild when the Dockerfile is newer than the stamp) ───────
# Previously this stamp depended on a FORCE target, which marked every
# ISO/ELF out of date on every `make`. Depend on the Dockerfile instead.
#
# The stamp only proves the image was built at some point in the past; it
# doesn't prove the image still exists in the local Docker daemon (e.g. after
# `docker system prune` or a fresh machine/context). Detect that case at
# parse time and drop the stale stamp so the image gets rebuilt.
ifneq ($(wildcard .docker-image),)
ifneq ($(shell command -v docker 2>/dev/null),)
ifeq ($(shell docker image inspect $(DOCKER_IMG) >/dev/null 2>&1 && echo yes),)
$(shell rm -f .docker-image)
endif
endif
endif

.docker-image: tools/Dockerfile
docker build --platform $(DOCKER_PLATFORM) --load -t $(DOCKER_IMG) -f tools/Dockerfile .
Expand Down
Loading