Repository navigation
clojure.xml/parse: vector :content, joined text runs - #5
Merged
Merged
Conversation
JVM clojure.xml conjes content onto [], so a non-empty :content is a vector and an empty element's is nil; the shim returned a seq. It also pushed each CHARACTERS event as its own string, so text split around an entity or a CDATA section came back in pieces. Adjacent pieces are joined now, and a whitespace-only run is dropped as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JVM clojure.xml builds :content with conj onto [], so non-empty content is a vector and an empty element has nil. The shim returned a seq, which breaks code that indexes into it or checks vector?.
It also pushed every CHARACTERS event as a separate string, so text split around an entity or a CDATA section (
t<![CDATA[x]]>u) came back in pieces where clojure.xml gives one string. Adjacent pieces are joined now; whitespace-only runs are still dropped.README test commands said joltc; it's jolt.