Fix recursive functions have higher inclusive cost than main#142
Open
TRowbotham wants to merge 1 commit into
Open
Fix recursive functions have higher inclusive cost than main#142TRowbotham wants to merge 1 commit into
TRowbotham wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the example given in #33 without trying to detect cycles. The costs of a calling function are reported as inclusive costs. When recursion happens, we don't want to add the inclusive cost of the called function to the calling function as they represent the same cost. This prevents inflating the inclusive cost of recursive functions, which should leave
{main}with the highest inclusive cost.