Repository navigation
Fail closed when wizard exclude_patterns is not a list - #94
Merged
Merged
Conversation
…list A YAML string for exclude_patterns was wiped to [] by yaml-generate and iterated as characters by /api/scan. Require string lists at Config load and in merge_defaults; missing keys still default. Co-authored-by: jmjava <jmjava@gmail.com>
Local ruff, pytest, and docgen benchmark are green on this branch. Co-authored-by: jmjava <jmjava@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
wizard.exclude_patternsis a list of glob strings. A YAML string was wiped to[]byyaml-generatemerge_defaults, and wizard/api/scaniterated it as characters (fnmatchover"a","r", …).wizard.scan_extensionsas a string similarly overwrote the default extension list.Change
Config.from_yamlrequireswizard.exclude_patterns/wizard.scan_extensionsto be YAML lists of strings when present.merge_defaultsraisesValueErrorinstead of replacing a non-listexclude_patternswith[].Milestone:
milestones/wizard-exclude-lists.mdOut of scope
exclude_patterns: []remains allowed (archive dirs are still skipped viais_under_archive_dir).