Repository navigation
Fail closed on pages.segments lists and context path types - #90
Merged
Merged
Conversation
A list pages.segments was ignored in favor of discovery. A non-list narration_from_source.context.paths became an empty focus set. Require mappings and string lists at config load. Co-authored-by: jmjava <jmjava@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
pages.segmentsas a list was ignored; pages fell back to discovery and dropped maintainer titlesnarration_from_source.context.pathsas a non-list (except a single string in library helpers) became an empty focus setmanim_scene_generationas a list was not in the Config mapping-key gateChange
Config.from_yamlnow requires:pages.segmentsto be a mapping when presentnarration_from_source/manim_scene_generationhints,context.paths,context.globsto be string listssegmentsmaps to be mappings of mappingspagesalso raises ifpages.segmentsis present and not a mapping.Milestone:
milestones/context-path-lists.mdOut of scope
_as_str_liststill wraps a single string as one path for callers that skipConfig.from_yamlpages.segments: {}still falls back to discoveryTesting
Local:
ruff check src/ tests/— cleanpytest tests/— 571 passed, 1 skippeddocgen benchmark— meetssrc/docgen/benchmark_data/baseline.json(no clock change)CI on this branch is the merge gate.