Repository navigation
Fail closed when concat targets or pages extra_links are not lists - #84
Merged
Merged
Conversation
A string concat.<name> was iterated as characters. Reject non-list concat targets at config load and in ConcatBuilder. pages.extra_links items must be href/label mappings. Co-authored-by: jmjava <jmjava@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #83 (
milestones/config-mapping-keys.md). Milestone:milestones/concat-segment-lists.md.Problem
concat.full: "01"(a string) was iterated as the characters0and1.pages.extra_linksentries that were not mappings traceback'd onlnk["href"].Changes
Config.from_yamlrejects non-listconcat.<name>values (ConfigError).ConcatBuilderalso rejects non-list targets (ConcatError).pages.extra_linksitems must be{href, label}mappings;docgen pagesmaps the error toClickException.Empty
concat:remains a no-op (bundles that do not stitch a full demo).Clock /
_TimedScenemath is unchanged; no baseline bump.Test plan
pytest tests/ -q— 545 passed, 1 skippedruff check src/ tests/docgen benchmark— meets baseline