Repository navigation
Fail closed on missing scenes.py, invalid docgen.yaml, and empty TTS - #82
Merged
Merged
Conversation
Reject invalid or non-mapping docgen.yaml instead of traceback or rewriting
as {}. Validate manim_scene_lint when scenes.py is missing. TTS with empty
segments.all and corrupt timing.json in scene_asset_validate now error.
Co-authored-by: jmjava <jmjava@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #81 (
milestones/wizard-narration-paths.md). Milestone:milestones/manim-lint-config.md.Problem
Several remaining silent-success paths:
validatemanim_scene_linttreated a missinganimations/scenes.pyas a pass/skip even when the segment is a Manimvisual_maprow.docgen.yamltraceback'd (YAMLError/AttributeError) or, in wizard hint-save, was rewritten as{}.docgen ttswith emptysegments.allexited 0 without generating anything.scene_asset_validateswallowed corrupttiming.jsonand skipped word-based cadence checks.Changes
ConfigError+load_yaml_mapping(): empty document →{}; invalid YAML or non-mapping root is an error. CLI mapsConfigErrortoClickException.yaml-generateand wizard hint-save use that loader (no wipe).scenes.pyfailsmanim_scene_lint(hard fail on--pre-push).segments.all(no--segment) raisesTTSError.timing.jsonis reported byscene_asset_validate.Clock /
_TimedScenemath is unchanged; no baseline bump.Test plan
pytest tests/ -v --tb=shortruff check src/ tests/docgen benchmark