Repository navigation
Fail closed on validate skips, empty Manim lists, and missing context - #80
Merged
Merged
Conversation
Treat missing narration and untimed paced specs as validate failures. Use visual_map scene names when manim.scenes is empty, reject image-generate --all with Manim segments but no specs, and error on declared context paths that do not exist. Co-authored-by: jmjava <jmjava@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #79.
docgen validateand a few remaining CLI skips were still reporting success on listed work that never ran.Validate
narration_lintfails when a listed segment has no narration file (same contract asdocgen lint)story_endfails when a Manim spec has paced labels buttiming.jsonhas no words (rundocgen timestamps). All-pace: nonespecs still skip.CLI
docgen manimwith an emptymanim.sceneslist usespipeline_manim_scene_names()fromvisual_mapvisual_maprows with no class name are an error instead of a silent no-opdocgen image-generate --allfails when Manim segments exist butanimations/specs/is emptyMissing recordings stay a pre-push warning.
Local:
pytest tests/→ 520 passed, 1 skipped.Milestone:
milestones/validate-fail-closed.md