Repository navigation
Fail closed when hint segment create is not a YAML boolean - #116
Merged
Merged
Conversation
Quoted create: "false" was truthy, so yaml-generate still inserted the segment. List stem was str()'d into segment_names; list id was skipped. Co-authored-by: jmjava <jmjava@gmail.com>
Record PR #116 and pytest / benchmark results on the milestone. Co-authored-by: jmjava <jmjava@gmail.com>
jmjava
marked this pull request as ready for review
September 7, 2026 21:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
yaml-generateinsertssegments.allids fromhints/*.mdwhendocgen.segment.createis truthy. Quotedcreate: "false"is a non-empty string, so it still declared the segment. A liststemwasstr()'d intosegment_names; a listidfailed the\d{2}check and was skipped as if the hint were prose-only.YAML
create: falsealready skipped. Integerid: 5still pads to"05".Change
parse_hint_segment_declarationrequires:createto be a YAML booleanstemto be a YAML stringidto be a YAML string or integer (not bool/list)Milestone:
milestones/hint-segment-create-bool.mdTests
create: "false"raisesstem/idraisecreate: falseskip and integerid: 5pad tests remain