-
Notifications
You must be signed in to change notification settings - Fork 1
feat(integrations): add Phase 2 optional integrations #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
445c8dd
feat(api): add REST API integration with web dashboard
jkkicks e2832d6
fix: add api init
jkkicks 0c8629f
feat(mqtt): add MQTT pub/sub client integration
jkkicks f75bd7c
feat(websocket): add WebSocket streaming server
jkkicks cbc9ad1
feat(robot): add TCP and ROS2 robot interfaces
jkkicks 1b8127a
fix: add dashboard page and upate roadmap/toml
jkkicks 9dc9a27
fix: remove unused ignore comment and update paho-mqtt version depend…
jkkicks 2af2bda
ci: add CodeRabbit AI review configuratio
jkkicks 864c4d1
fix(config): correct pre_merge_checks key names in coderabbit config
jkkicks 1547aa3
docs(api): add blank lines before fenced code blocks
jkkicks 73664a7
fix(config): remove unsupported mypy from coderabbit tools
jkkicks File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,141 @@ | ||
| # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json | ||
|
|
||
| language: "en-US" | ||
| early_access: false | ||
|
|
||
| reviews: | ||
| profile: "assertive" | ||
| request_changes_workflow: true | ||
| high_level_summary: true | ||
| high_level_summary_in_walkthrough: true | ||
| review_status: true | ||
| commit_status: true | ||
| collapse_walkthrough: false | ||
| changed_files_summary: true | ||
| sequence_diagrams: true | ||
| poem: false | ||
| abort_on_close: true | ||
|
|
||
| # Path-specific review instructions | ||
| path_instructions: | ||
| - path: "src/cnckit/core/**/*.py" | ||
| instructions: | | ||
| This is the core module - it must remain lean and dependency-free. | ||
| - No external dependencies allowed (only Python stdlib) | ||
| - All public APIs must have type hints | ||
| - Ensure backwards compatibility | ||
| - Check for thread safety in Machine and Scheduler classes | ||
|
|
||
| - path: "src/cnckit/integrations/**/*.py" | ||
| instructions: | | ||
| These are optional integration modules with external dependencies. | ||
| - Each integration must validate its dependencies on import | ||
| - Must raise ImportError with install instructions if deps missing | ||
| - Should integrate with EventEmitter for event binding | ||
| - Check that optional deps are in pyproject.toml extras | ||
|
|
||
| - path: "tests/**/*.py" | ||
| instructions: | | ||
| Test files should follow pytest conventions. | ||
| - Use fixtures appropriately | ||
| - Mock external services, don't make real connections | ||
| - Test both success and error paths | ||
| - Integration tests should be marked with @pytest.mark.integration | ||
|
|
||
| - path: "docs/**/*.md" | ||
| instructions: | | ||
| Documentation uses MkDocs with Material theme. | ||
| - Code examples should be runnable | ||
| - API references use mkdocstrings format (:::) | ||
| - Keep examples simple and focused | ||
|
|
||
| # Files to exclude from review | ||
| path_filters: | ||
| - "!**/*.lock" | ||
| - "!**/poetry.lock" | ||
| - "!**/.gitignore" | ||
| - "!**/uv.lock" | ||
|
|
||
| auto_review: | ||
| enabled: true | ||
| auto_incremental_review: true | ||
| drafts: false | ||
| ignore_title_keywords: | ||
| - "WIP" | ||
| - "DO NOT MERGE" | ||
| - "wip" | ||
| base_branches: | ||
| - "main" | ||
| - "develop" | ||
|
|
||
| # Finishing touches - auto-suggest improvements | ||
| finishing_touches: | ||
| docstrings: | ||
| enabled: true | ||
| unit_tests: | ||
| enabled: true | ||
|
|
||
| # Pre-merge quality checks | ||
| pre_merge_checks: | ||
| title: | ||
| mode: "warning" | ||
| requirements: | | ||
| Follow conventional commits format: | ||
| - Start with type: feat, fix, docs, chore, refactor, test, ci | ||
| - Optional scope in parentheses: feat(core), fix(mqtt) | ||
| - Imperative mood: "add feature" not "added feature" | ||
| - Under 72 characters | ||
|
|
||
| description: | ||
| mode: "warning" | ||
|
|
||
| issue_assessment: | ||
| mode: "off" | ||
|
|
||
| # Static analysis tools (mypy runs via CI, not CodeRabbit) | ||
| tools: | ||
| ruff: | ||
| enabled: true | ||
| markdownlint: | ||
| enabled: true | ||
| github-checks: | ||
| enabled: true | ||
| timeout_ms: 120000 | ||
|
|
||
| chat: | ||
| auto_reply: true | ||
|
|
||
| knowledge_base: | ||
| opt_out: false | ||
| learnings: | ||
| scope: "auto" | ||
| issues: | ||
| scope: "local" | ||
| pull_requests: | ||
| scope: "local" | ||
|
|
||
| code_generation: | ||
| docstrings: | ||
| language: "en-US" | ||
| path_instructions: | ||
| - path: "src/cnckit/**/*.py" | ||
| instructions: | | ||
| Use Google-style docstrings. | ||
| Include Args, Returns, Raises sections as appropriate. | ||
| Keep descriptions concise but complete. | ||
|
|
||
| unit_tests: | ||
| path_instructions: | ||
| - path: "src/cnckit/core/**/*.py" | ||
| instructions: | | ||
| Generate pytest-style tests. | ||
| Use fixtures from conftest.py when available. | ||
| Test edge cases and error conditions. | ||
| Mock time-dependent operations. | ||
|
|
||
| - path: "src/cnckit/integrations/**/*.py" | ||
| instructions: | | ||
| Generate pytest-style tests. | ||
| Mock all external service connections. | ||
| Test import error when dependencies missing. | ||
| Test event binding functionality. | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.