(feat) Include modern device attributes in the /zones response - #920
Open
Trudge wants to merge 1 commit into
Open
(feat) Include modern device attributes in the /zones response#920Trudge wants to merge 1 commit into
Trudge wants to merge 1 commit into
Conversation
Add the AirPlay, microphone, wifi, HDMI CEC and Trueplay attributes exposed by the sonos-discovery Player model to each coordinator and member in /zones. Note: the fields resolve to undefined until node-sonos-discovery is updated to a version that exposes them (see the matching change there).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include the AirPlay, microphone, WiFi, wireless mode, room calibration (Trueplay) and HDMI CEC attributes exposed by the sonos-discovery Player model in each coordinator and member of the /zones response. Fields resolve to undefined until node-sonos-discovery is updated to expose them.