Work around Clang/Windows init order bug by using static all_suites - #53
Open
polter-rnd wants to merge 1 commit into
Open
Work around Clang/Windows init order bug by using static all_suites#53polter-rnd wants to merge 1 commit into
polter-rnd wants to merge 1 commit into
Conversation
Owner
|
While I'm fairly sure this is a compiler bug, if we did work around this, I think the right way would be to just revert the relevant part of 7a9adee and use the old implementation: inline suites_list & all_suites() {
static suites_list all;
return all;
} |
Contributor
Author
|
I think it makes sense to revert it then, otherwise it's not usable on Clang/Windows. Shall I update the MR? |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change replaces the inline definition of
all_suiteswith astaticone to avoid static initialization order issues, particularly on Clang + Windows.This ensures
all_suitesis initialized before any static test registrations, in accordance with the C++ standard, which guarantees initialization order for static variables within a single translation unit.However, this imposes a limit on test executable to have only one translation unit. Not sure how to do it better without explicit initialization point and slightly more boilerplate, which this patch avoids for now.
Fixes #52