Cleanup Apple implementation#23
Open
complexspaces wants to merge 4 commits into
Open
Conversation
Its parameter types more obviously map to Rust's compilation model
Contributor
Author
|
Interestingly, the tests sometimes fail on my MacBook, both on I'm not sure if this is just a fluke or something to be worried about. |
The mach APIs used are available and non-restricted on watchOS and visionOS as well
Owner
|
That's definitely unexpected. Returning To be totally honest, I don't really need this crate any more, as the only time it's used in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves the confusing type size implications pointed out in a recent report and additionally cleans up the other type casing done inside the Apple implementation to be cleaner. It also handles a trivial
libcdeprecation I noticed opening up a fresh clone of the repository.Commit-by-commit review is recommended.
Closes #22