Make Jenkins approve Merge Requests

[klausbayrhammer]

Gitlab EE v 7.12.0 introduced the feature 'Project setting: approve merge request by N users before accept'. We'd like to configure that there are 2 approvals required in order to merge a MR. One of the approvals should be done by the jenkins build which builds the MR. As far as I can see a merge-request-triggered jenkins build adds a comment to the MR - it would be cool if the jenkins build would approve the merge-request.

[capricube]

+1 i'd also like to use jenkins as an approver

[MartinNowak]

Or maybe use the 👎 👍 voting to trigger a merge, that would also be availabe for the Gitlab CE.

[carleytanoue-disney]

+1 for jenkins as an approver!

[brentjohnson]

+1 (Unless there is a less hacky way to enforce "No merging unless you pass unit tests")

[kflorence]

+1

[omehegan]

@dblessing what would Jenkins have to send back in order to give a +1 to a merge request?

[omehegan]

#110 added support for Jenkins accepting MR.
#72 added support for Jenkins voting on an MR.

Seems like these together should be enough for this issue. Any comments?

[dblessing]

As of GitLab 8.5.0, the "Merge when build succeeds" feature will work with
this plugin. Is that enough or do you want total autonomous control for
Jenkins to merge?
On Thu, Feb 25, 2016 at 6:33 PM Owen Mehegan notifications@github.com
wrote:

#110 #110 added support
for Jenkins accepting MR.
#72 #72 added support
for Jenkins voting on an MR.

Seems like these together should be enough for this issue. Any comments?

—
Reply to this email directly or view it on GitHub
#95 (comment)
.

[omehegan]

It isn't clear to me what exactly people are asking for, or whether it is already supported by the plugin. I thought that the "Accept merge request on successful build" feature is it, and the author of that code said it was working in his setup. So now I don't understand what is changing on the GitLab side in 8.5.0 :)

[coder-hugo]

The author requested to add the functionality to approve a MR instead of accepting it by the Jenkins. Approving MRs is a feature of the GitLab EE (You can configure that a MR requires a given number of approvals before it can be accepted). But AFAIK there is no API provided by GitLab for approving MRs. At least I haven't found any documentation for this.
@dblessing: do you know if there is an API for this or if it's planned to implement an API for this.

[kalibyrn]

I noticed this was closed. Has this been completed, dropped, or is it duplicated in some way? One of our projects is requesting that merges cannot be accepted until a successful build and this request would fit the bill nicely.

Would this be doable via the functionality of this pull request? #72

[omehegan]

@kalibyrn from what we can tell, "approve MR" is a feature of GitLab EE only. As far as we know, there is no API on the GitLab side that we could use to send this approval from Jenkins. So the plugin currently supports things like "voting" (+1), commenting, and actually accepting/merging MRs. If you want this other functionality, we don't see a way to provide it currently.

[borgiani]

@omehegan it seems that they have an API for that now: https://docs.gitlab.com/ee/api/merge_requests.html#approve-merge-request
Any chance we can see this issue reopened? :)