Skip to content

Fix ready_for_review pull request event handling - #1553

Open
insan3d wants to merge 1 commit into
jenkinsci:masterfrom
insan3d:fix/ready-for-review-event
Open

Fix ready_for_review pull request event handling#1553
insan3d wants to merge 1 commit into
jenkinsci:masterfrom
insan3d:fix/ready-for-review-event

Conversation

@insan3d

@insan3d insan3d commented Aug 20, 2026

Copy link
Copy Markdown

Description

Fix handling of the GitHub ready_for_review pull request event.

Draft pull requests are intentionally not indexed, so no Jenkins job exists for them. When such a pull request becomes ready for review, the event must be treated as SCMEvent.Type.CREATED, allowing Jenkins to discover the PR and create its job.

See GitHub Issue #1514.

Submitter checklist

  • Link to issue in description, if appropriate.
  • Change is code complete and matches issue description
  • Automated tests have been added to exercise the changes
  • Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.

Reviewer checklist

  • Run the changes and verify that the change matches the issue description
  • Reviewed the code
  • Verified that the appropriate tests have been written or valid explanation given

Documentation changes

  • No documentation changes are needed for this internal event-handling fix.

Users/aliases to notify

Manual test instructions

  1. Install the built HPI in a test Jenkins instance.
  2. Configure a GitHub Multibranch Pipeline with the Ignore pull requests marked as drafts trait.
  3. Open a draft pull request.
  4. Verify that Jenkins does not create a job for the draft PR.
  5. Mark the pull request as ready for review.
  6. Verify that Jenkins receives the webhook, discovers the PR, creates the job, and triggers the initial build.

@insan3d
insan3d requested a review from a team as a code owner August 20, 2026 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant