Improve error message for multiple implementations in HeteroDescribableConfigurator#2852
Merged
timja merged 2 commits intoJun 14, 2026
Conversation
timja
approved these changes
Jun 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2589
JCasC actually already correctly rejects multiple implementations for a single-valued HeteroDescribable (like serverConfiguration in the OpenID Connect plugin) and fails the configuration. The underlying validation logic is already working as intended.
However, when this conflict occurs, JCasC throws a very generic IllegalArgumentException:
Single entry map expected to configure a <type>While technically correct, the error does not identify which configuration entries caused the conflict, requiring users to inspect the configuration manually to determine the source of the problem.
This PR improves HeteroDescribableConfigurator.configureMapping to explicitly list the conflicting keys provided by the user, making configuration mistakes immediately clear.
Added a test covering a nested single-valued Describable configured with multiple implementations and verifying that the conflicting entries are reported in the exception message.
Your checklist for this pull request
🚨 Please review the guidelines for contributing to this repository.