refactor: use atomics#29
Draft
jdockerty wants to merge 4 commits into
Draft
Conversation
Moves the conditional reset check to the beginning so that an out of bounds access does not occur
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrapping a
usizewithin anArc<RwLock<T>>is basically atomics with extra steps. The mutexes/locks build upon atomics and we really only need the value for what is being used here. The extra complexity of wrapping values within locks is not required, we can use atomics directly.Whether the memory ordering is correct is up for debate, but this is okay for now.