feat(cli): accept YouTube URLs in addition to video IDs#586
Open
hr0dv1tn1r wants to merge 1 commit intojdepoix:masterfrom
Open
feat(cli): accept YouTube URLs in addition to video IDs#586hr0dv1tn1r wants to merge 1 commit intojdepoix:masterfrom
hr0dv1tn1r wants to merge 1 commit intojdepoix:masterfrom
Conversation
Previously _sanitize_video_ids only stripped backslashes from raw video IDs. This change extends it to also detect and parse full YouTube URLs, automatically extracting the 11-character video ID. Supported URL formats: - https://www.youtube.com/watch?v=VIDEO_ID - https://youtu.be/VIDEO_ID - https://www.youtube.com/embed/VIDEO_ID - https://www.youtube.com/v/VIDEO_ID URLs with extra query parameters (e.g. &t=30s) are handled correctly. Bare video IDs continue to work unchanged. Multiple video arguments mixing IDs and URLs are fully supported. Tests added for all supported URL formats and mixed inputs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously _sanitize_video_ids only stripped backslashes from raw video IDs. This change extends it to also detect and parse full YouTube URLs, automatically extracting the 11-character video ID.
Supported URL formats:
URLs with extra query parameters (e.g. &t=30s) are handled correctly. Bare video IDs continue to work unchanged. Multiple video arguments mixing IDs and URLs are fully supported.
Tests added for all supported URL formats and mixed inputs.