Repository navigation
Throw IOException from FileUtils.getContentsAsString when the file cannot be read - #652
Open
Sarthak-Shreshtha01 wants to merge 1 commit into
Conversation
…nnot be read getContents(File) returns null for a directory, a missing file or a failed read, and getContentsAsString passed that null to new String(), so callers got a NullPointerException instead of the IOException the method declares. Fixes javapathfinder#649 Signed-off-by: Sarthak <sarthakshreshtha345@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getContentsAsString(File)passed thenullfromgetContents(File)straight tonew String(), so reading a directory or an unreadable file threw aNullPointerException. It now throws anIOExceptionnaming the file.getContents(File)is unchanged, sinceCachedROHttpConnectionrelies on itsnullreturn.Added
FileUtilsTest: one test reads a file normally, one reads a directory and expectsIOException(it failed with the NPE before this change).Fixes #649