Repository navigation
Keep the NumberFormatException message from Integer, Long and Short parsing - #647
Open
anishmehta24 wants to merge 1 commit into
Open
anishmehta24 wants to merge 1 commit into
anishmehta24 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
parseInt/parseLong/parseShortpeers catch the hostNumberFormatExceptionand throw a new one in the program without its message, sogetMessage()isnullunder JPF:They now pass the message on (
Bytealready gets it, since it is not a peer).Added
IntegerTest.testParseErrorKeepsMessage, which fails on master. It only checks that the message mentions the input, because the exact wording comes from the host JDK. Tested on Windows 11 with Temurin 11.0.32:parallelTestpasses (1033), andsingleThreadTesthas only the twoURLClassLoaderTestfailures that also happen on Windows on master (#427, fixed in #644).