Repository navigation
Throw out-of-range String indices in the program instead of failing JPF - #646
Open
anishmehta24 wants to merge 1 commit into
Open
anishmehta24 wants to merge 1 commit into
anishmehta24 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Stringpeer passes the program's indices straight to the hostString, so an out-of-range index throws in the host JVM, andNativeMethodInfoturns that into aJPFNativePeerExceptionthat stops the search. For examplethrows
StringIndexOutOfBoundsExceptionon a normal JVM, but under JPF it ends withexception in native method java.lang.String.substring. Acatchin the program never runs, and an uncaught one is not reported as aNoUncaughtExceptionsPropertyviolation.The same happens for
charAt,codePointAt,codePointBefore,codePointCount,offsetByCodePoints,getChars,getBytes(int, int, byte[], int), bothsubstrings and theString(char[]/int[]/byte[], offset, count)constructors, plus an unknown charset name inString(byte[], int, int, String). These now catch the exception and throw it in the program withenv.throwException, the waygetBytes(String)already does.checkBoundsOffCountthrew a host exception directly; it now throws in the program too.Tested on Windows 11 with Temurin 11.0.32: the two new
StringTestcases fail on master and pass with this change. Full./gradlew test: 1048 passed, and the only failures are the twoURLClassLoaderTestcases that also fail on Windows on master (#427, fixed in #644).