Restore the working directory after nested Path contexts - #258
Open
vitalivo wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces #256, which was accidentally closed and its source fork deleted. The implementation is unchanged; the original discussion and reviews remain linked there.
Nesting
with directory:twice with the samePathinstance overwrites the saved working directory. The outer context then leaves the process indirectoryinstead of restoring its original location.Keep a stack of previous directories, pushing only after
chdirsucceeds and popping on exit. Adds normal-exit and exception-unwinding regressions, plus a changelog fragment.Both regressions fail before the change. Validation: 144 tests/doctests passed, 1 skipped on Python 3.10 and 3.14. Changed files pass Ruff formatting, and Ruff check introduces no diagnostics compared with the base revision.