Raise on existing files in mkdir_p and makedirs_p - #257
Open
vitalivo wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces #255, which was accidentally closed and its source fork deleted. The implementation is unchanged; the original discussion and reviews remain linked there.
Path.mkdir_p()andPath.makedirs_p()silently succeeds when its path is an existing regular file. Its documented exception is for an existing directory, so callers can incorrectly proceed assuming a usable directory was created.Only suppress FileExistsError if the existing path is a directory. Added regressions for file collisions in both methods and a control for creating a new directory, alongside the existing directory test. Includes a changelog fragment.
Validation: the file-collision tests fail before the fix; 145 tests/doctests pass (1 skipped) on Python 3.10 and 3.14. Ruff formatting passes; the current lint diagnostics are identical to the base revision.