Skip to content

feat(i18n): add Japanese localization - #2

Open
yuu1111 wants to merge 6 commits into
itvincent-git:mainfrom
yuu1111:feat/japanese-i18n
Open

feat(i18n): add Japanese localization#2
yuu1111 wants to merge 6 commits into
itvincent-git:mainfrom
yuu1111:feat/japanese-i18n

Conversation

@yuu1111

@yuu1111 yuu1111 commented Aug 20, 2026

Copy link
Copy Markdown

Summary

  • Add Japanese localization for the full application UI
  • Detect Japanese browser locale automatically
  • Add Japanese to the language selector
  • Fill in missing entries found in the existing locales while adding Japanese support
  • Allow localized settings navigation labels to wrap within the sidebar

Test plan

  • pnpm typecheck
  • pnpm test
  • Verify locale key and placeholder parity
  • Build and run the Tauri application locally
  • Verify Japanese language selection and settings navigation layout

@itvincent-git itvincent-git left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding Japanese localization! The overall implementation looks good.

I tested the PR against the latest main: typecheck, tests, production build, and placeholder parity all pass.

Before merging, could you please update/rebase the branch onto the latest main and add the following recently introduced Japanese locale
entries?

  • sessions.quota.usage_and_remaining
  • sessions.quota.used_and_remaining_change
  • sessions.quota.usage_label

Currently en.json contains 575 keys while ja.json contains 572, so these strings fall back to English in the Japanese UI.

Please also rerun the locale key parity check after updating. Thanks!

@yuu1111
yuu1111 requested a review from itvincent-git August 22, 2026 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants