Feature/cr 011 unified lifecycle

DHF/items/02_req_sys/SYS-TRANS-001.yaml

@@ -0,0 +1,8 @@
+id: SYS-TRANS-001
+title: Transition Test
+content: Testing transitions
+category: Functional
+status: approved
+file_path: /Users/chenwenliang/code/CompliantFlow/DHF/items/02_req_sys/SYS-TRANS-001.yaml
+approved_by: tester
+approved_date: '2025-01-01'

DHF/items/09_cr/CR-011.yaml

@@ -0,0 +1,29 @@
+id: CR-011
+title: refactor the status management of object
+type: CR
+status: submitted
+description: "Current status definition is too complex and should be simplified. \n\
+  \nThere should be a collection of all the lifecycle status and action in the configuration\
+  \ - \naction: create -> status: draft\naction: submit for review -> status: in review\
+  \ \naction: approve -> status: approved \naction: start implementation -> status:\
+  \ implementing \naction: complete -> status: completed\naction: start verification\
+  \ -> status: verified\naction: start validation -> status validated\naction: acceptance\
+  \ assessment -> status accept\naction: retire -> status: retired\naction: close\
+  \ -> status: closed\n\nThen, for each object, the property can be configured:\n\
+  name: lifecycle_status\ncurrent_status: none\nsupport_actions:\n- create\ncurrent_status:\
+  \ draft\nsupport_actions:\n- approve\n- retire\ncurrent_status: approved\nsupport_actions:\n\
+  - retire\n\nAnd, every action shall recorded as atom data, including who and when\
+  \ this change is performed. This is not necessary to be configured, it's a forced\
+  \ policy."
+justification: unify the status management.
+priority: High
+file_path: /Users/chenwenliang/code/CompliantFlow/DHF/items/09_cr/CR-011.yaml
+affected_items:
+- SYS-TRANS-001
+- TC-SRS-006
+- TC-SRS-008
+- TC-SRS-015
+implementation_prs:
+- pr_number: 12
+  pr_url: https://github.com/itercharles/CompliantFlow/pull/12
+  title: Feature/cr 011 unified lifecycle

pytest.ini

@@ -1,3 +1,4 @@
 [pytest]
+addopts = -p no:anyio
 markers =
     browser: marks tests as browser tests (deselect with '-m "not browser"')

src/app.py

@@ -24,59 +24,33 @@
 from utils.ui_helpers import check_and_show_item_detail
 
 
-def get_dhf_root(config_file: str = None) -> Path:
+def get_dhf_root() -> Path:
     """
     Get DHF root directory from configuration.
 
-    Args:
-        config_file: Path to app_config.yaml (optional)
-
     Returns:
         Path to DHF directory
     """
+    # Check for environment variable override (used by tests)
+    import os
+    env_dhf = os.environ.get("COMPLIANTFLOW_DHF_ROOT")
+    if env_dhf:
+        print(f"[APP] Using DHF from environment: {env_dhf}")
+        return Path(env_dhf)
+
     # Default to production DHF
-    default_dhf = Path(__file__).resolve().parent.parent / "DHF"
-
-    # If no config file specified, use default location
-    if config_file is None:
-        config_file = Path(__file__).resolve().parent.parent / "app_config.yaml"
-    else:
-        config_file = Path(config_file)
-
-    # If config file doesn't exist, use default
-    if not config_file.exists():
-        return default_dhf
-
-    # Read config file
-    try:
-        with open(config_file, 'r') as f:
-            config_data = yaml.safe_load(f) or {}
-
-        if 'dhf_root' in config_data:
-            dhf_path = config_data['dhf_root']
-            # Resolve relative paths from project root
-            if not Path(dhf_path).is_absolute():
-                project_root = Path(__file__).resolve().parent.parent
-                return project_root / dhf_path
-            return Path(dhf_path)
-    except Exception as e:
-        st.warning(f"Failed to load config file {config_file}: {e}. Using default DHF.")
-
-    return default_dhf
+    return Path(__file__).resolve().parent.parent / "DHF"
 
 
 # Initialize Core
 @st.cache_resource
-def get_core(_config_file: str = None):
+def get_core():
     """
-    Initialize CompliantFlowCore with DHF from configuration.
-
-    Args:
-        _config_file: Path to app_config.yaml (optional, prefixed with _ for st.cache)
+    Initialize CompliantFlowCore.
 
-    Note: dhf_root is read from config and used as implicit cache key
+    Note: DHF root is resolved dynamically.
     """
-    dhf_root = get_dhf_root(_config_file)
+    dhf_root = get_dhf_root()
     return CompliantFlowCore(dhf_root)
 
 
@@ -161,7 +135,7 @@ def home_page():
 # === CORE INITIALIZATION ===
 try:
     # Get config file path (use default location)
-    st.session_state.core = get_core(None) # None will use default app_config.yaml location
+    st.session_state.core = get_core()
 except Exception as e:
     st.error(f"Failed to initialize CompliantFlow Core: {e}")
     st.stop()

src/pages/02_Traceability.py

@@ -88,34 +88,8 @@ def get_shape_by_type(item_id: str) -> str:
 
 def should_show_warning(item: dict, core) -> bool:
     """Check if item should show warning icon based on lifecycle state."""
-    item_status = item.get('status', 'draft')
-    item_id = item['id']
-
-    # Get doc type for this item
-    doc_type_code = get_doc_type_code(item_id)
-    doc_type_config = core.config.get_doc_type(doc_type_code)
-
-    if not doc_type_config:
-        raise ValueError(f"Document type configuration not found for: {doc_type_code}")
-
-    if not doc_type_config.lifecycle:
-        raise ValueError(f"Lifecycle configuration missing for document type: {doc_type_code}")
-
-    # Get lifecycle states
-    lifecycle = doc_type_config.lifecycle
-    states = lifecycle.get('states', [])
-
-    if not states:
-        raise ValueError(f"No states defined in lifecycle for document type: {doc_type_code}")
-
-    # Find stable states (states with is_stable: true)
-    stable_states = [s.get('id') for s in states if s.get('is_stable', False)]
-
-    if not stable_states:
-        raise ValueError(f"No stable states configured for document type: {doc_type_code}. Add 'is_stable: true' to appropriate states.")
-
-    # Show warning if not in a stable state
-    return item_status not in stable_states
+    # Use core.is_item_editable() which checks global lifecycle
+    return core.is_item_editable(item)
 
 def build_matrix_table(all_items: List[dict], path: List[str], core) -> pd.DataFrame:
     """Build traceability table for a specific matrix configuration."""

src/pages/ui_components.py

@@ -173,7 +173,7 @@ def render_item_card(
     item: Dict[str, Any],
     item_type: str,
     core: Any,
-    workflow_engine: Any = None,
+
     show_actions: bool = True
 ) -> None:
     """
@@ -183,7 +183,7 @@ def render_item_card(
         item: Item dictionary
         item_type: Type prefix (CRS, SYS, SDS, etc.)
         core: CompliantFlowCore instance
-        workflow_engine: DynamicWorkflowEngine instance for state info
+
         show_actions: Whether to show action buttons
     """
     with st.expander(f"▼ {item['id']} - {item.get('title', 'N/A')}", expanded=False):
@@ -192,8 +192,8 @@ def render_item_card(
         with col1:
             current_status = item.get('status', 'unknown')
             state_config = None
-            if workflow_engine:
-                state_config = workflow_engine.get_state_info(current_status)
+            if True:  # Always use core
+                state_config = core.get_state_info(current_status)
 
             render_status_badge(
                 current_status,
@@ -225,8 +225,8 @@ def render_item_card(
                         link_status = linked_item.get('status', 'unknown')
                         # Get state config for linked item to show appropriate icon
                         link_icon = '📄'
-                        if workflow_engine:
-                            link_state = workflow_engine.get_state_info(link_status)
+                        if True:  # Always use core
+                            link_state = core.get_state_info(link_status)
                             link_icon = link_state.get('icon', '📄')
                         st.write(f"{link_icon} → {link_id}: {linked_item.get('title', 'N/A')}")
                     with col2:
@@ -236,8 +236,8 @@ def render_item_card(
 
         # Actions - show available transitions
         if show_actions and workflow_engine:
-            current_status = item.get('status', workflow_engine.get_initial_state())
-            available_transitions = workflow_engine.get_available_transitions(current_status)
+            current_status = item.get('status', core.get_initial_state(item["id"].split("-")[0]))
+            available_transitions = core.get_available_transitions(item)
 
             if available_transitions:
                 st.markdown("---")