Tests: leave the working tree clean after a full run - #53
Open
Andrei-Errapart wants to merge 1 commit into
Open
Conversation
Every test run dirtied two tracked files: tests/COVERAGE.md (only its "Generated:" timestamp line changed) and TestData/Generated/Individual/ PCB/BODY_3D_STEP_CHECKSUM0.PcbLib (rewritten with only the OLE directory FILETIMEs differing). Drop the timestamp line from the coverage report and rewrite the file only when its content actually changed. Save the zero-checksum PcbLib to the system temp directory instead of TestData, make FileComparisonTest regenerate that variant in memory rather than reading the file from disk, and untrack the generated fixture.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every full test run dirtied two tracked files:
tests/COVERAGE.md(only its "Generated:" timestamp line changed) andTestData/Generated/Individual/PCB/BODY_3D_STEP_CHECKSUM0.PcbLib(rewritten with only the OLE directory FILETIMEs differing). This meantdotnet testalways left the working tree dirty. After this change a full test run leaves all tracked files untouched.Changes
CoverageReportTests.GenerateCoverageReport: drop the "Generated:" timestamp line from the coverage report and rewritetests/COVERAGE.mdonly when its content actually changed.tests/COVERAGE.md: regenerated once without the timestamp line.RawDataPreservationTest.PcbLib_SaveWithZeroChecksum: save the zero-checksum PcbLib to the system temp directory instead of intoTestData/.FileComparisonTest.CompareOriginalAndWrittenPcbLib: regenerate the zero-checksum variant in memory (readBODY_3D_STEP.PcbLib, zero the model checksums, save to aMemoryStream) instead of reading the generated file from disk, which also removes the implicit ordering dependency onRawDataPreservationTest.TestData/Generated/Individual/PCB/BODY_3D_STEP_CHECKSUM0.PcbLib.Test Plan
dotnet test) — 850 passed, 10 skipped, 0 failed;git statusreports no modified tracked files after the runChecklist