Skip to content

Upgrade Yew to 0.22 - #56

Merged
isosphere merged 3 commits into
isosphere:mainfrom
EatonWu:main
Feb 8, 2026
Merged

Upgrade Yew to 0.22#56
isosphere merged 3 commits into
isosphere:mainfrom
EatonWu:main

Conversation

@EatonWu

@EatonWu EatonWu commented Feb 3, 2026

Copy link
Copy Markdown

Addresses #54 (comment)

A couple of considerations here; I observed a hash change for the bootstrap js include because of a message in the console when running the examples, which is kind of odd, and suspicious.

Other than that, I wasn't really sure how to handle the ToHtml trait removal; I think it might actually be an issue on the Yew side because ToPropValue wasn't implemented for String, I think:
yewstack/yew#3443 (comment)

Which necessitated a change to the format strings. Anyway, I just wrapped the format strings in Html::from() for now, which seems to resolve the errors.

I also fixed some warnings regarding my pull request @ #55

ewu added 2 commits February 3, 2026 10:16
Missed a doctest in accordion.rs
Lock files updated
@isosphere

isosphere commented Feb 8, 2026

Copy link
Copy Markdown
Owner

Which necessitated a change to the format strings. Anyway, I just wrapped the format strings in Html::from() for now, which seems to resolve the errors.

I've come to the same conclusion as you; Html::from() seems to do the job nicely. Not as nicely as not having to specify it in the first place, but it'll do! I've commented in the linked issue, maybe they'll let us know if this is suboptimal.

The hash you've updated matches what I see at https://getbootstrap.com/docs/5.1/getting-started/download/, so that change is appropriate. I agree it's strange that it's changed - but maybe a new version of their minifier changed the output?

I think the changes to modal.rs are unnecessary; I'm thinking you got some clippy lints for unused code there. I've added some #[allow(dead_code)] for these to prevent that in future.

Thank you for your submission!

@isosphere
isosphere merged commit d97edb3 into isosphere:main Feb 8, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants