Skip to content

Remove DNS record handling from the BMC reconciler #1094

Description

@afritzler

Summary

The BMC reconciler currently creates a DNS record for each BMC by rendering a YAML template and applying it to the cluster. This should be removed. DNS records for BMCs should be managed outside the operator, not rendered and applied as a side effect of BMC reconciliation.

Why

Managing DNS records is not part of the BMC reconciler's job. The feature ties the operator to a specific DNS provider's resource shape, requires an extra template file to be mounted into the manager, and adds a whole render-and-apply path that has nothing to do with actually managing a BMC. Fewer moving parts in
the reconciler means less to maintain and less that can break.

What to remove

  • The DNS record creation step in the BMC reconciler, together with the template rendering logic and the reconciler's template field.
  • The --dns-record-template-path manager flag and the code that loads the template on startup.
  • The internal helper package that reads the template file (nothing else uses it).
  • The example template ConfigMap in config/manager.
  • The test setup, test assertions, and test fixture covering DNS record creation.
  • The DNS record section in the BMC documentation (docs/concepts/bmcs.md).

Afterwards, regenerate manifests so any RBAC permissions that existed only for applying DNS records are dropped.

Heads-up for users

DNS records previously created by the operator are owned by their BMC and are garbage-collected along with it. Anyone relying on this feature needs to manage these records themselves going forward. This should be called out in the release notes.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions