Skip to content

Remove year from license headers - #566

Merged
afritzler merged 1 commit into
mainfrom
chore/565-remove-year-license-headers
Sep 9, 2026
Merged

afritzler merged 1 commit into
mainfrom
chore/565-remove-year-license-headers

Conversation

@friegger

@friegger friegger commented Sep 9, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #565

Summary by CodeRabbit

  • Documentation
    • Updated SPDX copyright notices across project source, test, configuration, and documentation files.
    • Removed fixed copyright years and standardized attribution wording.
    • No functional behavior or public interfaces were changed.

Signed-off-by: Felix Riegger <felix.riegger@sap.com>
@friegger
friegger requested a review from a team as a code owner September 9, 2026 11:39
@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 9bf92dc1-9218-421a-acb0-c5c7a6b361a5

📥 Commits

Reviewing files that changed from the base of the PR and between 11d827d and 8d79a62.

📒 Files selected for processing (22)
  • REUSE.toml
  • cmd/machine-controller/main.go
  • hack/license-header.txt
  • pkg/api/v1alpha1/doc.go
  • pkg/api/v1alpha1/provider.go
  • pkg/api/validation/validation.go
  • pkg/api/validation/validation_suite_test.go
  • pkg/api/validation/validation_test.go
  • pkg/ignition/config.go
  • pkg/ironcore/create_machine.go
  • pkg/ironcore/create_machine_test.go
  • pkg/ironcore/delete_machine.go
  • pkg/ironcore/delete_machine_test.go
  • pkg/ironcore/driver.go
  • pkg/ironcore/get_machine_status.go
  • pkg/ironcore/get_machine_status_test.go
  • pkg/ironcore/get_volume_ids.go
  • pkg/ironcore/get_volume_ids_test.go
  • pkg/ironcore/list_machines.go
  • pkg/ironcore/list_machines_test.go
  • pkg/ironcore/suite_test.go
  • pkg/ironcore/testing/testing.go

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The pull request replaces year-specific SPDX copyright text with year-free attribution in REUSE.toml, the license header template, and existing Go source and test files. No functional code changes were made.

Changes

License header migration

Layer / File(s) Summary
Update SPDX copyright text
REUSE.toml, hack/license-header.txt, cmd/machine-controller/main.go, pkg/api/..., pkg/ignition/config.go, pkg/ironcore/...
Existing copyright headers and annotations now omit fixed years while retaining the stated copyright holders and SPDX markers.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 8d79a

This change removes years from SPDX copyright text while retaining license markers and makes no functional code changes. No current merge-blocking risk is identified.

Suggested reviewers: afritzler

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description only includes Fixes #565`` and omits the required Proposed Changes section and change summary. Add the # Proposed Changes section with concise bullets describing the license-header updates, while retaining Fixes #565``. [1]
Linked Issues check ⚠️ Warning The PR addresses the license-header migration, but pkg/ironcore/get_volume_ids.go is reported as using 2022–present, which still contains a year and violates issue #565's year-free header requirem… Change pkg/ironcore/get_volume_ids.go to the year-free SPDX copyright text and verify that all tracked files have year-free headers. Run and confirm make check-license passes. [#565]
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: removing years from license headers.
Out of Scope Changes check ✅ Passed The changes are limited to SPDX copyright-header updates in the listed files and support the objectives of issue #565. No unrelated code or functional changes are reported.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Full details: Linked Issues check

Explanation

The PR addresses the license-header migration, but pkg/ironcore/get_volume_ids.go is reported as using 2022–present, which still contains a year and violates issue #565's year-free header requirement. The provided context also does not confirm that make check-license passes.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/565-remove-year-license-headers

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@afritzler
afritzler merged commit 32cdf9e into main Sep 9, 2026
10 checks passed
@afritzler
afritzler deleted the chore/565-remove-year-license-headers branch September 9, 2026 13:08
@hardikdr hardikdr added the area/gardener-extension Gardener extension integration. label Sep 10, 2026
@hardikdr hardikdr added this to Roadmap Sep 10, 2026
@github-project-automation github-project-automation Bot moved this to Done in Roadmap Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/gardener-extension Gardener extension integration. chore provider

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Remove years from existing license headers

3 participants