Skip to content

Remove deprecated image field from volumeSpec - #552

Merged
lukasfrank merged 1 commit into
ironcore-dev:mainfrom
opensovereigncloud:osc/feat/remove-deprecated-image-field
Jul 16, 2026
Merged

lukasfrank merged 1 commit into
ironcore-dev:mainfrom
opensovereigncloud:osc/feat/remove-deprecated-image-field

Conversation

@Rohit-0505

@Rohit-0505 Rohit-0505 commented Jul 14, 2026 •

Copy link
Copy Markdown
Contributor

Proposed Changes

  • Remove the deprecated image field from machine's volumeSpec
  • Update the test to validate the change
  • Update the go.mod with latest ironcore commit that holds the deprecated image field api change

/ref ironcore-dev/ironcore#1495

Summary by CodeRabbit

  • Bug Fixes
    • Improved root disk image configuration for machines created through IronCore.
    • Ensured ephemeral volume templates correctly include the requested storage capacity.
    • Updated machine creation behavior to provide more consistent volume and operating system image settings.

Signed-off-by: Rohit Kumar <rohit.1si09ee045@gmail.com>
@Rohit-0505
Rohit-0505 requested a review from a team as a code owner July 14, 2026 06:45
@coderabbitai

coderabbitai Bot commented Jul 14, 2026 •

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The IronCore dependency is updated, root disk images are wired through the volume template’s OS datasource, and the machine creation test expects a 10Gi storage resource.

Changes

Root disk volume integration

Layer / File(s) Summary
Root disk datasource and volume expectations
go.mod, pkg/ironcore/create_machine.go, pkg/ironcore/create_machine_test.go
Updates the IronCore dependency, assigns root disk images through the OS datasource, and verifies the ephemeral volume’s 10Gi storage resource.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related issues

  • ironcore-dev/ironcore#1495 — The change adopts spec.dataSource.osImage.image instead of the deprecated spec.image field.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarizes the main change: removing the deprecated image field from volumeSpec.
Description check ✅ Passed The description is specific and matches the template’s proposed changes section, with only the exact Fixes # footer omitted.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lukasfrank
lukasfrank merged commit 6af2f04 into ironcore-dev:main Jul 16, 2026
12 checks passed
@hardikdr hardikdr added the area/gardener-extension Gardener extension integration. label Aug 21, 2026
@hardikdr hardikdr added this to Roadmap Aug 22, 2026
@github-project-automation github-project-automation Bot moved this to Done in Roadmap Aug 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/gardener-extension Gardener extension integration. provider size/M

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants