Avoid false fuzzing constraint failures at pointer boundaries - #818
Merged
Alan-Jowett merged 1 commit intoSep 30, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused change correctly addresses boundary ambiguity without weakening constraints for other unknown values.
Review effort: Balanced
Findings: None
What changed in this PR
Prevents false fuzz-oracle failures by leaving ambiguous pointer-boundary values unconstrained.
Changes:
- Exempts packet, stack, and context end values from scalar constraints.
- Retains signed/unsigned constraints for other unknown values.
| File | Description |
|---|---|
libfuzzer/libfuzz_harness.cc |
Handles ambiguous boundary values during verifier constraint checks. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fuzzing job found a minimized crash in the constraint-checking oracle for an empty packet. Values equal to data_end, stack_end, or the context boundary are ambiguous: they can represent verifier pointers or numeric values produced by arithmetic. Leave those boundary values unconstrained while retaining concrete signed/unsigned constraints for other unknown values. Reproduced and fixed the minimized crash locally; a short constrained fuzz run also completes successfully.