Skip to content

Python 3.14 clean - #89

Closed
lormafe34 wants to merge 3 commits into
intra2net:masterfrom
lormafe34:python-3.14-clean
Closed

lormafe34 wants to merge 3 commits into
intra2net:masterfrom
lormafe34:python-3.14-clean

Conversation

@lormafe34

@lormafe34 lormafe34 commented Jul 20, 2026 •

Copy link
Copy Markdown
Contributor

Added support for Python 3.14 to the CI workflow and fixed the formatting issues.

Summary by CodeRabbit

  • Tests

    • CI now runs the test suite across Python 3.10–3.14.
    • CI triggers are limited to changes targeting the main branches.
  • Chores

    • Lint checks now run against Python 3.12 and 3.13.
    • Updated README formatting for improved readability.

@coderabbitai

coderabbitai Bot commented Jul 20, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 792039d0-5a1d-4752-bf5c-e9b7d2ee0922

📥 Commits

Reviewing files that changed from the base of the PR and between 5439f78 and 2ded8cf.

📒 Files selected for processing (2)
  • .github/workflows/ci.yml
  • .github/workflows/lint.yml
💤 Files with no reviewable changes (1)
  • .github/workflows/ci.yml
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/lint.yml

📝 Walkthrough

Walkthrough

CI triggers are limited to main and master, a Python-version build matrix is added, lint targets explicit Python versions, and README whitespace is adjusted.

Changes

CI workflow updates

Layer / File(s) Summary
Build workflow triggers and test matrix
.github/workflows/ci.yml
CI runs for main and master pushes and pull requests, executes pytest across Python 3.10–3.14, and includes a minor macOS environment-line change.
Lint Python matrix
.github/workflows/lint.yml
Lint setup explicitly targets Python 3.12 and 3.13.

README formatting

Layer / File(s) Summary
README whitespace adjustments
README.md
Blank lines are added or adjusted without changing README content.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is related to the main change by calling out Python 3.14 support, even though "clean" is vague.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/ci.yml:
- Around line 1-32: Fix the CI workflow YAML by removing the stray “yaml” entry,
correcting list-item syntax to use spaces after hyphens, and preserving valid
indentation under the build job and its steps. Update the
dependency-installation step to install requirements from
packaging/pip_requirements.txt and install the project before running pytest,
matching the project’s existing dependency setup.

In @.github/workflows/lint.yml:
- Line 15: Update the python-version input in the lint workflow from a YAML
sequence to a multiline string containing both 3.12 and 3.13, preserving the
intended installation of both versions and fixing the invalid GitHub Action
input type.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fd824d42-ed6b-43be-a131-a2277ec6f175

📥 Commits

Reviewing files that changed from the base of the PR and between c38b1ad and 5439f78.

📒 Files selected for processing (3)
  • .github/workflows/ci.yml
  • .github/workflows/lint.yml
  • README.md

Comment thread .github/workflows/ci.yml
Comment thread .github/workflows/lint.yml Outdated
with:
python-version: '3.x'

python-version: ['3.12', '3.13']

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🔴 Critical | ⚡ Quick win

Fix invalid GitHub Action input type.

GitHub Action inputs must be strings, but a YAML sequence (array) is provided here. This will cause the workflow to fail with a syntax error (expected scalar node for string value but found sequence node).

If you intended to install multiple Python versions, use a multiline string. However, since the linting commands are not using a matrix, installing multiple versions will simply leave the python command pointing to the last installed version. If you meant to run the lint job on both versions separately, you should use a strategy.matrix as done in ci.yml.

To fix the immediate syntax error by installing both versions, format it as a multiline string:

🐛 Proposed fix (multiline string)
       - name: Set up Python
         uses: actions/setup-python@v5
         with:
-          python-version: ['3.12', '3.13']
+          python-version: |
+            3.12
+            3.13
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
python-version: ['3.12', '3.13']
python-version: |
3.12
3.13
🧰 Tools
🪛 actionlint (1.7.12)

[error] 15-15: expected scalar node for string value but found sequence node with "!!seq" tag

(syntax-check)

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/lint.yml at line 15, Update the python-version input in
the lint workflow from a YAML sequence to a multiline string containing both
3.12 and 3.13, preserving the intended installation of both versions and fixing
the invalid GitHub Action input type.

Source: Linters/SAST tools

@coderabbitai coderabbitai Bot mentioned this pull request Jul 20, 2026
@pevogam

pevogam commented Jul 23, 2026

Copy link
Copy Markdown
Member

Closed as duplicate to #87.

@pevogam pevogam closed this Jul 23, 2026
@coderabbitai coderabbitai Bot mentioned this pull request Jul 29, 2026
@lormafe34
lormafe34 deleted the python-3.14-clean branch September 10, 2026 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants