Repository navigation
Conversation
Ported from @internetarchive/result-type 0.0.1. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CjuFdHEwY7MowcqkUxxudu
* origin/WEBDEV-9417-result-type: WEBDEV-9417: Migrate result-type into elements
Ported from @internetarchive/metadata-service 1.1.1. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CjuFdHEwY7MowcqkUxxudu
|
The identifier and key path went into the request URL as they were, so `../services/user` or `x?y=1` changed which archive.org URL got fetched. Each part is encoded now, and `.` and `..` parts are refused. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CjuFdHEwY7MowcqkUxxudu
Collaborator
Author
|
Second commit is a security fix beyond the port. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## WEBDEV-9419-item-metadata #174 +/- ##
=============================================================
- Coverage 91.73% 91.67% -0.06%
=============================================================
Files 126 131 +5
Lines 4075 4158 +83
Branches 858 876 +18
=============================================================
+ Hits 3738 3812 +74
- Misses 147 152 +5
- Partials 190 194 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CjuFdHEwY7MowcqkUxxudu
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves metadata-service into
src/services/metadata-service/, ported from @internetarchive/metadata-service 1.1.1 (tag v1.1.1, same as the published source). All 15 tests came over with the assertions unchanged. It imports the local item-metadata and result-type.MetadataServiceErrorTypeis a const object with a same-named type and the same values, because the repo forbids enums. The entry point isindex.ts, sincemetadata-service.tsis the class. The open upstream writes PR (metadata-service#20, WEBDEV-9151) is not included.Stacked on #171 (item-metadata). The branch also carries #156 (result-type) until it merges.
🤖 Generated with Claude Code
https://claude.ai/code/session_01CjuFdHEwY7MowcqkUxxudu