Repository navigation
Conversation
Ported from @internetarchive/result-type 0.0.1. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CjuFdHEwY7MowcqkUxxudu
* origin/WEBDEV-9417-result-type: WEBDEV-9417: Migrate result-type into elements
Ported from @internetarchive/search-service 2.7.2. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CjuFdHEwY7MowcqkUxxudu
|
A field or value of __proto__ or constructor reached Object.prototype or the Object constructor. FilterMapBuilder now ignores those keys. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CjuFdHEwY7MowcqkUxxudu
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## WEBDEV-9419-item-metadata #172 +/- ##
=============================================================
+ Coverage 91.73% 92.00% +0.27%
=============================================================
Files 126 152 +26
Lines 4075 4701 +626
Branches 858 1026 +168
=============================================================
+ Hits 3738 4325 +587
- Misses 147 163 +16
- Partials 190 213 +23 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Second commit is a security fix beyond the port. |
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CjuFdHEwY7MowcqkUxxudu
Only `__proto__` is ignored, and lookups use own-property checks, so a facet value like "prototype" or "constructor" still works. setFilterMap goes through mergeFilterMap. Same tests as WEBDEV-9479. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CjuFdHEwY7MowcqkUxxudu
|
Updated the FilterMapBuilder fix to match iaux-search-service#103 (WEBDEV-9479): only |
| constructor(options?: SearchBackendOptionsInterface) { | ||
| super(options); | ||
| this.servicePath = | ||
| options?.servicePath ?? '/services/search/beta/page_production'; |
There was a problem hiding this comment.
NOTE: Sure wish we could get rid of that /beta part of the path...
Moves search-service into
src/services/search-service/, ported from @internetarchive/search-service 2.7.2 (the published source). All 209 tests came over, converted from mocha and sinon to vitest. It imports the local item-metadata and result-type. Changes from a straight port:SearchType,AggregationSortType,FilterConstraint,SearchServiceErrorType) are const objects with a same-named type, with the same values, because the repo forbids enums.subjecton the hit classes is typedStringListField. Against item-metadata 1.5.0 the oldStringFieldtype no longer compiles (type only, no runtime change).index.tssincesearch-service.tsis the class.Stacked on #171 (item-metadata). The branch also carries #156 (result-type) until it merges.
🤖 Generated with Claude Code
https://claude.ai/code/session_01CjuFdHEwY7MowcqkUxxudu