Skip to content

WEBDEV-9422: Migrate user-service into elements - #170

Open
jbuckner wants to merge 3 commits into
WEBDEV-9418-migrate-field-parsersfrom
WEBDEV-9422-user-service
Open

jbuckner wants to merge 3 commits into
WEBDEV-9418-migrate-field-parsersfrom
WEBDEV-9422-user-service

Conversation

@jbuckner

@jbuckner jbuckner commented Oct 9, 2026

Copy link
Copy Markdown
Collaborator

Moves user-service into src/services/user-service/, ported from @internetarchive/user-service 1.0.0 (tag v1.0.0, same commit as npm). All 22 tests came over, converted from mocha and sinon to vitest. It imports the local field-parsers and result-type. UserServiceErrorType is a const object plus a union type because the repo forbids enums. typescript-cookie is a new dependency. The tests still use the npm @internetarchive/local-cache as a dev dependency until WEBDEV-9174 moves it in.

Stacked on #152 (field-parsers). The branch also carries #156 (result-type) until that merges, so this diff includes its files.

🤖 Generated with Claude Code

https://claude.ai/code/session_01CjuFdHEwY7MowcqkUxxudu

jbuckner and others added 3 commits October 8, 2026 16:40
Ported from @internetarchive/result-type 0.0.1.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CjuFdHEwY7MowcqkUxxudu
* origin/WEBDEV-9417-result-type:
  WEBDEV-9417: Migrate result-type into elements
Ported from @internetarchive/user-service 1.0.0.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CjuFdHEwY7MowcqkUxxudu
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
PR Preview Action v1.8.1

🚀 View preview at
https://internetarchive.github.io/elements/pr/pr-170/

Built to branch ghpages at 2026-10-09 00:39 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.06%. Comparing base (5640b86) to head (9718828).

Additional details and impacted files
@@                          Coverage Diff                          @@
##           WEBDEV-9418-migrate-field-parsers     #170      +/-   ##
=====================================================================
+ Coverage                              90.85%   91.06%   +0.20%     
=====================================================================
  Files                                    105      110       +5     
  Lines                                   3457     3536      +79     
  Branches                                 835      846      +11     
=====================================================================
+ Hits                                    3141     3220      +79     
  Misses                                   131      131              
  Partials                                 185      185              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants