Repository navigation
Conversation
Ported from @internetarchive/result-type 0.0.1. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CjuFdHEwY7MowcqkUxxudu
* origin/WEBDEV-9417-result-type: WEBDEV-9417: Migrate result-type into elements
Ported from @internetarchive/user-service 1.0.0. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CjuFdHEwY7MowcqkUxxudu
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## WEBDEV-9418-migrate-field-parsers #170 +/- ##
=====================================================================
+ Coverage 90.85% 91.06% +0.20%
=====================================================================
Files 105 110 +5
Lines 3457 3536 +79
Branches 835 846 +11
=====================================================================
+ Hits 3141 3220 +79
Misses 131 131
Partials 185 185 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves user-service into
src/services/user-service/, ported from @internetarchive/user-service 1.0.0 (tag v1.0.0, same commit as npm). All 22 tests came over, converted from mocha and sinon to vitest. It imports the local field-parsers and result-type.UserServiceErrorTypeis a const object plus a union type because the repo forbids enums.typescript-cookieis a new dependency. The tests still use the npm@internetarchive/local-cacheas a dev dependency until WEBDEV-9174 moves it in.Stacked on #152 (field-parsers). The branch also carries #156 (result-type) until that merges, so this diff includes its files.
🤖 Generated with Claude Code
https://claude.ai/code/session_01CjuFdHEwY7MowcqkUxxudu