Working example of using the python sdk#14
Open
johngian wants to merge 3 commits intointerledger:mainfrom
Open
Working example of using the python sdk#14johngian wants to merge 3 commits intointerledger:mainfrom
johngian wants to merge 3 commits intointerledger:mainfrom
Conversation
83d14d6 to
1117cf6
Compare
1117cf6 to
a7f3b3f
Compare
* Use OutgoingPaymentWithSpentAmounts to pass model verification * Fix hash mismatch because of trailing slash * Add default=None for optional fields * Fix assignment typo on get_outgoing_payments * Make updatedAt optional because some time the API response doesn't return it * Minor oversights because of lack of testing in a real env
* Docs for the example are on README.md * Uses docker-compose to simplify orchestration * It replicates the example from the nodejs sdk repo * Spins off a temporary sidecar service to handle callback
* Everything is locked to current latest * Remove deprecated dependency and serialize field manually
a7f3b3f to
2a9b5f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes some issues identified in the code while running a real world example. On top of that, it replicates the peer to peer example from the nodejs implementation of the SDK. This was done in order to have a once off way to verify that the majority of the functionality can work in a real environment.
This PR ships with some docs under
/examples/peer-to-peer/README.mdon what the example does.