Skip to content

Migrate kernels to use AT_DISPATCH_V2 - #4446

Open
pbielak wants to merge 1 commit into
mainfrom
migrate-ops-to-dispatch-v2
Open

Migrate kernels to use AT_DISPATCH_V2#4446
pbielak wants to merge 1 commit into
mainfrom
migrate-ops-to-dispatch-v2

Conversation

@pbielak

@pbielak pbielak commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Convert legacy AT_DISPATCH_FLOATING_TYPES_AND2 and AT_DISPATCH_ALL_TYPES_AND3 usages to AT_DISPATCH_V2 in:

  • src/ATen/native/xpu/sycl/FusedAdamKernels.cpp
  • src/ATen/native/xpu/sycl/FusedAdamAmsgradKernels.cpp
  • src/ATen/native/xpu/sycl/FusedAdamWKernels.cpp
  • src/ATen/native/xpu/sycl/FusedAdamWAmsgradKernels.cpp
  • src/ATen/native/xpu/sycl/Embedding.cpp
  • src/ATen/native/nested/xpu/sycl/NestedTensorTransformerFunctionKernels.cpp

These kernels / files are already using the new dispatch in upstream.

@github-actions github-actions Bot added disable_e2e Disable all e2e test jobs for the PR disable_distributed Disable distributed UT test jobs for the PR labels Jul 24, 2026
@pbielak
pbielak force-pushed the migrate-ops-to-dispatch-v2 branch 2 times, most recently from 3bae01f to 2d14f53 Compare July 24, 2026 15:39

@BBBela BBBela left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!
Please just check if the #include <ATen/Dispatch.h> are not unused imports after switching to v2 version.

Comment thread src/ATen/native/xpu/sycl/FusedAdamAmsgradKernels.cpp Outdated
@pbielak
pbielak force-pushed the migrate-ops-to-dispatch-v2 branch from 2d14f53 to 2ac6c54 Compare July 27, 2026 13:53
Convert legacy `AT_DISPATCH_FLOATING_TYPES_AND2` and `AT_DISPATCH_ALL_TYPES_AND3`
usages to `AT_DISPATCH_V2` in:
- src/ATen/native/xpu/sycl/FusedAdamKernels.cpp
- src/ATen/native/xpu/sycl/FusedAdamAmsgradKernels.cpp
- src/ATen/native/xpu/sycl/FusedAdamWKernels.cpp
- src/ATen/native/xpu/sycl/FusedAdamWAmsgradKernels.cpp
- src/ATen/native/xpu/sycl/Embedding.cpp
- src/ATen/native/nested/xpu/sycl/NestedTensorTransformerFunctionKernels.cpp

These kernels / files are already using the new dispatch in upstream.
@pbielak
pbielak force-pushed the migrate-ops-to-dispatch-v2 branch from 2ac6c54 to 17a658c Compare July 27, 2026 13:54
@pbielak
pbielak requested a review from BBBela July 27, 2026 13:54

@BBBela BBBela left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving 😉 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

disable_distributed Disable distributed UT test jobs for the PR disable_e2e Disable all e2e test jobs for the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants