Use native add_custom_command DEPFILE for SYCL header deps#4356
Open
cyyever wants to merge 1 commit into
Open
Conversation
Replaces the make2cmake .d-to-.cmake conversion and configure-time include() dance with CMake's native DEPFILE, so header dependencies update every build instead of only on reconfigure.
guangyey
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the
make2cmake.d-to-.cmakeconversion and the configure-timeinclude()dance with CMake's nativeadd_custom_command(DEPFILE ...). Headerdependencies now update on every build instead of only on the next reconfigure,
and
make2cmake.cmakeis deleted (net -142 lines). Relies onCMP0116 NEW,already active via
cmake_minimum_required(3.27).