Make MathExtensions device constants constexpr#4347
Draft
cyyever wants to merge 1 commit into
Draft
Conversation
The special-function locals were `static const`, which on device carries a guard variable. Switch the literal scalars and the is_same-selected ones to constexpr (with is_same_v); coefficient tables are left as-is.
cyyever
marked this pull request as draft
July 15, 2026 05:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The special-function locals in
MathExtensions.hwerestatic const, which on device carries a guard variable and static storage. This switches the literal scalars (PI_f64,EXP1,lanczos_g,MAXITER,SMALL/LARGE/*RATIO) and theis_same<>::value-selected ones (MAXLOG,MACHEP,BIG,BIGINV) toconstexpr, and modernizes theiris_same<>::value/is_same<>()tois_same_v. Coefficient tables and arrays are left as-is.Authored with the assistance of an AI coding agent (Claude).