Repository navigation
Fix PDB source paths and undeprecate ack and nack - #45
Merged
Merged
Conversation
Also reword the skip warning to "Skipped {operation} of message".
There was a problem hiding this comment.
🟢 Approval recommended
The changes are narrowly scoped and internally consistent, with no unresolved blocking findings.
No open issues 🎉
What changed in this PR
This PR corrects published PDB source paths to support Ionide go-to-definition and clarifies the supported acknowledgement APIs.
Changes:
- Configure publishing to use the SDK from
global.jsonand an explicit source path mapping. - Remove deprecation guidance from three acknowledgement helpers while retaining it for
tryNackWithDelayBlocking. - Reword skipped-operation warnings and update the matching test expectation.
| File | Description |
|---|---|
src/Insurello.RabbitMqClient/RabbitMqClient.fs |
Update API documentation and skipped-operation warning text. |
src/Insurello.RabbitMqClient.Tests/ConnectionClosedTest.fs |
Match the revised delayed-nack warning. |
.github/workflows/publish_to_NuGet.yml |
Set up the configured SDK and correct package source path mapping. |
.github/workflows/build.yml |
Upgrade actions/setup-dotnet to v6. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
/_//src/...source paths into the PDB of the published package with the SDK's default path mapping. They don't match the/_/src/...paths in the F# metadata, so go to definition into the package fails in Ionide.ack,nackandnackWithDelayNonBlockingwere marked as deprecated, but they're still useful when the caller doesn't need the outcome: they log a skip due to a closed connection as a warning themselves.Solution
global.jsonand pack with-p:PathMap=$PWD=/_. Bumpactions/setup-dotnetto v6 in the build workflow.ack,nackandnackWithDelayNonBlocking, and point to thetryfunctions for callers that want to handle the outcome. OnlytryNackWithDelayBlockingstays deprecated.