Repository navigation
chore: pass block-associated span with simenv and simresult - #151
Merged
Merged
Conversation
prestwich
marked this pull request as ready for review
September 17, 2025 19:47
Evalir
approved these changes
Sep 17, 2025
Evalir
left a comment
Evalir
left a comment
Member
There was a problem hiding this comment.
very cool. really wanna see how this looks in prod
Member
Author
|
cc @dylanlott I think this causes minimal rebase issues with your PR? |
dylanlott
approved these changes
Sep 18, 2025
dylanlott
left a comment
dylanlott
left a comment
Contributor
There was a problem hiding this comment.
LGTM. There are no merge conflicts since we already separated out the builder helper from the flashbots submitter tasks. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces per-task spans with a single span that is passed through the env -> build -> submit tasks