Skip to content

Add support for compare fn on View.sortMethod#277

Open
isBatak wants to merge 3 commits into
release/v1from
feat/view-sort-method-compare-fn
Open

Add support for compare fn on View.sortMethod#277
isBatak wants to merge 3 commits into
release/v1from
feat/view-sort-method-compare-fn

Conversation

@isBatak

@isBatak isBatak commented May 18, 2021

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread packages/datx/src/types.ts Outdated
@@ -0,0 +1,3 @@
export type PropertySelectorFn<T> = (item: T) => any;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this is a new thing... usually I handled types in the same way as interfaces (including the I prefix)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I move this to interfaces folder and use I prefix?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that would be great

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants