Repository navigation
docs(web-app-akaunting): drop the stale PHP 8.1 to-do - #1294
Conversation
The role builds akaunting/docker at master. Upstream moved that Dockerfile to `FROM php:8.2.35-apache` (akaunting/docker#123, merged 2026-10-26), a release with the fixes for CVE-2026-109618 and CVE-2026-109619, so the to-do that asked to move off PHP 8.1.34 no longer describes the image the role builds. Closes #1119 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Remove PHP upgrade TODO roles/web-app-akaunting/TODO.md |
The TODO entry about replacing PHP 8.1 with PHP 8.2 or later is removed. The OIDC auto-provisioning TODO remains. |
Priority:
Estimated code review effort: 1 (Trivial) | ~2 minutes
Change: Other
Possibly related PRs
- infinito-nexus/core#1244: This PR also concerns the Akaunting image and its PHP runtime version.
Merge Risk: 
Minimal · up to d3f38
-
No actionable issue in the TODO change was established. The change is mergeable after normal checks.
Pre-merge checks: 
4 · 
1
-
Failed checks: 1 inconclusive Passed checks: 4 passed-
Full details: Title check
-
Explanation
The title "docs(web-app-akaunting): drop the stale PHP 8.1 to-do" matches the only change in the changeset, which removes the outdated PHP 8.1 TODO line from roles/web-app-akaunting/TODO.md. It is specific, concise, and follows a conventional commit style. The title does not mention the underlying reason (the image now builds on PHP 8.2.35), but it does not need to.
Full details: Description check
-
Explanation
The description follows the repository's Fix template in substance. It has a summary, template type, affected role, change type, change details, local validation, security impact, and DoD sections. It explains the problem, the upstream evidence, and the single-line change. Gaps: the template's Preferred Integrations, File Checklist, and Review Focus sections are left as unchecked boilerplate, and the description does not describe a deployment or Playwright test. Those gaps are acceptable for a documentation-only change, but the author should confirm which template sections apply. The description also cites an upstream commit and issue (
#123and#1119) that the reviewer cannot verify from the diff alone.
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files.
-
Full details: Linked Issues check
-
Explanation
Issue [
#1119] requires a PHP 8.2+ fixed runtime, a fixed release reported byphp -v, green deployment and Playwright specs, and removal of the TODO entry. The diff removes the PHP 8.1 TODO entry. Existingmeta/services.ymlusesakaunting/dockeratref: master, and the compose template builds that checkout withDockerfile. The PR reports that upstreammasterusesphp:8.2.35-apache, but the repository does not contain that Dockerfile or a runtime result. The PR also reports no deployment,php -v, or Playwright validation.Resolution
Provide reviewable evidence for the upstream Dockerfile and the deployed container's
php -vresult. Provide the required deployment and Playwright results, or otherwise supply evidence that these acceptance criteria are satisfied.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Summary
Removes the akaunting to-do that asked to move off PHP 8.1. The role builds
akaunting/dockeratmaster, and upstream already moved that Dockerfile toFROM php:8.2.35-apache, a release with the fixes for CVE-2026-109618 and CVE-2026-109619. Closes #1119.Template Type
Affected Roles and Services
web-*role(s):web-app-akauntingweb-svc-*,sys-front-*,svc-db-*, auth, mail, proxy, or storage role(s): nonePreferred Integrations
Roles (optional
🧩 SubsetCI scope)Change Type
Change Details
roles/web-app-akaunting/TODO.mdstill said the image runsFROM php:8.1-apache(PHP 8.1.34, end of life).akaunting/docker@masterDockerfileline 1 isFROM php:8.2.35-apache(Upgrade images to PHP 8.2.35 (PHP2Shell fix) and support Akaunting 3.2 akaunting/docker#123, merged 2026-10-26). The role clones that ref on every deploy (meta/services.ymlref: master), so compose and swarm both build on 8.2.35. The evidence chain per mode is in the [Bug]: web-app-akaunting builds on end-of-life PHP 8.1 (CVE-2026-109618/109619 stay open) #1119 thread.File Checklist
README.mdmeta/main.ymlvars/main.ymlmeta/services.ymlmeta/server.ymltasks/main.ymlTODO.mdLocal Validation
akaunting/docker@master:FROM php:8.2.35-apachemake quality-high: test phase 4/4 green, lint phase 15/15 green; ansible-lint ran in full (0 failure(s), 0 warning(s) in 4272 files processed)Security Impact
Review Focus
Definition of Done (DoD)
Additional Notes
store-i18n carries the same line in
roles/web-app-akaunting/TODO.mdand drops it at its next main merge.🤖 Generated with Claude Code
Summary by CodeRabbit