Skip to content

docs(web-app-akaunting): drop the stale PHP 8.1 to-do - #1294

Merged
kevinveenbirkenbach merged 1 commit into
mainfrom
fix/web-app-akaunting/stale-php81-todo/1119
Oct 30, 2026
Merged

kevinveenbirkenbach merged 1 commit into
mainfrom
fix/web-app-akaunting/stale-php81-todo/1119

Conversation

@kevinveenbirkenbach

@kevinveenbirkenbach kevinveenbirkenbach commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Removes the akaunting to-do that asked to move off PHP 8.1. The role builds akaunting/docker at master, and upstream already moved that Dockerfile to FROM php:8.2.35-apache, a release with the fixes for CVE-2026-109618 and CVE-2026-109619. Closes #1119.


Template Type

  • Feature - Adds or extends server functionality
  • Fix - Repairs broken or incorrect server behavior

Affected Roles and Services

  • Primary web-* role(s): web-app-akaunting
  • Related web-svc-*, sys-front-*, svc-db-*, auth, mail, proxy, or storage role(s): none

Preferred Integrations

  • Dashboard
  • Matomo
  • OIDC
  • LDAP
  • Logout

Roles (optional 🧩 Subset CI scope)

roles:
  - web-app-akaunting

Change Type

  • Major - Breaking change
  • Minor - New backwards-compatible feature
  • Patch - Small improvement or compatible adjustment

Change Details


File Checklist

Check Item When to include Purpose
[ ] README.md Usually unchanged
[ ] meta/main.yml Usually unchanged
[ ] vars/main.yml Usually unchanged
[ ] meta/services.yml Usually unchanged
[ ] meta/server.yml Usually unchanged
[ ] tasks/main.yml Usually unchanged
[x] TODO.md When needed stale PHP 8.1 line removed

Local Validation

  • Deployment target and distro documented: no deploy (documentation-only change)
  • Upstream Dockerfile read at akaunting/docker@master: FROM php:8.2.35-apache
  • Playwright test run documented
  • Login flow tested
  • Logout flow tested
  • Screenshot attached when the change is user-visible
  • make quality-high: test phase 4/4 green, lint phase 15/15 green; ansible-lint ran in full (0 failure(s), 0 warning(s) in 4272 files processed)

Security Impact

  • No relevant security impact
  • Security impact present

Review Focus

  • Highest-risk files, roles, or flows: none
  • Migration, rollback, or security-sensitive concerns: none
  • Specific feedback requested from reviewers: none

Definition of Done (DoD)

  • The implementation follows the Definition of Done, and the contribution guidelines in CONTRIBUTING.md were considered and applied during implementation.

Additional Notes

store-i18n carries the same line in roles/web-app-akaunting/TODO.md and drops it at its next main merge.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Removed an outdated planning note about the PHP 8.1 image base. The existing OIDC auto-provisioning follow-up remains documented; no user-facing behavior changed.

The role builds akaunting/docker at master. Upstream moved that
Dockerfile to `FROM php:8.2.35-apache` (akaunting/docker#123, merged
2026-10-26), a release with the fixes for CVE-2026-109618 and
CVE-2026-109619, so the to-do that asked to move off PHP 8.1.34 no
longer describes the image the role builds.

Closes #1119

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 13a7753 and d3f3800.

Files selected for processing: 1
  • roles/web-app-akaunting/TODO.md
Files with no reviewable changes: 1
  • roles/web-app-akaunting/TODO.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The Akaunting role’s TODO file no longer contains the PHP 8.1 upgrade entry or its end-of-life and CVE references. The OIDC auto-provisioning TODO remains.

Changes: Akaunting TODO update

Layer / File(s) Summary
Remove PHP upgrade TODO
roles/web-app-akaunting/TODO.md
The TODO entry about replacing PHP 8.1 with PHP 8.2 or later is removed. The OIDC auto-provisioning TODO remains.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Possibly related PRs

Merge Risk: Minimal · up to d3f38

No actionable issue in the TODO change was established. The change is mergeable after normal checks.

Pre-merge checks: Passed 4 · Inconclusive 1

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Linked Issues check Inconclusive Issue [#1119] requires a PHP 8.2+ fixed runtime, a fixed release reported by php -v, green deployment and Playwright specs, and removal of the TODO entry. The diff removes the PHP 8.1 TODO entry. Ex… Provide reviewable evidence for the upstream Dockerfile and the deployed container's php -v result. Provide the required deployment and Playwright results, or otherwise supply evidence that these acceptance criteria are satisfied.
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title "docs(web-app-akaunting): drop the stale PHP 8.1 to-do" matches the only change in the changeset, which removes the outdated PHP 8.1 TODO line from roles/web-app-akaunting/TODO.md. It is spe…
Description check Passed The description follows the repository's Fix template in substance. It has a summary, template type, affected role, change type, change details, local validation, security impact, and DoD sections. It…
Out of Scope Changes check Passed The whole-PR diff changes only roles/web-app-akaunting/TODO.md. It removes the TODO entry directly related to issue [#1119]. No unrelated source, role, or service changes are present.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Full details: Title check

Explanation

The title "docs(web-app-akaunting): drop the stale PHP 8.1 to-do" matches the only change in the changeset, which removes the outdated PHP 8.1 TODO line from roles/web-app-akaunting/TODO.md. It is specific, concise, and follows a conventional commit style. The title does not mention the underlying reason (the image now builds on PHP 8.2.35), but it does not need to.

Full details: Description check

Explanation

The description follows the repository's Fix template in substance. It has a summary, template type, affected role, change type, change details, local validation, security impact, and DoD sections. It explains the problem, the upstream evidence, and the single-line change. Gaps: the template's Preferred Integrations, File Checklist, and Review Focus sections are left as unchecked boilerplate, and the description does not describe a deployment or Playwright test. Those gaps are acceptable for a documentation-only change, but the author should confirm which template sections apply. The description also cites an upstream commit and issue (#123 and #1119) that the reviewer cannot verify from the diff alone.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files.

Full details: Linked Issues check

Explanation

Issue [#1119] requires a PHP 8.2+ fixed runtime, a fixed release reported by php -v, green deployment and Playwright specs, and removal of the TODO entry. The diff removes the PHP 8.1 TODO entry. Existing meta/services.yml uses akaunting/docker at ref: master, and the compose template builds that checkout with Dockerfile. The PR reports that upstream master uses php:8.2.35-apache, but the repository does not contain that Dockerfile or a runtime result. The PR also reports no deployment, php -v, or Playwright validation.

Resolution

Provide reviewable evidence for the upstream Dockerfile and the deployed container's php -v result. Provide the required deployment and Playwright results, or otherwise supply evidence that these acceptance criteria are satisfied.

Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kevinveenbirkenbach
kevinveenbirkenbach merged commit 22ff50c into main Oct 30, 2026
26 of 28 checks passed
@kevinveenbirkenbach
kevinveenbirkenbach deleted the fix/web-app-akaunting/stale-php81-todo/1119 branch October 30, 2026 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: web-app-akaunting builds on end-of-life PHP 8.1 (CVE-2026-109618/109619 stay open)

1 participant