Skip to content

I71954 - #4

Open
monroi wants to merge 18 commits into
mainfrom
i71954
Open

I71954#4
monroi wants to merge 18 commits into
mainfrom
i71954

Conversation

@monroi

@monroi monroi commented Sep 4, 2026

Copy link
Copy Markdown

No description provided.

@monroi
monroi requested a review from ewohnlich September 4, 2026 20:16
view.manageUser(users=(rec,))
assert api.user.get("siteadmin").getProperty("active") == "inactive"

def test_cant_deactivate_manager(self, portal):

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why this was removed?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed it because it wasn't doing what the name suggested. It's suppose to be testing that a manager stays activate even when it's been set to inactivate. So originally I had changed rec = RequestRecord(id="manager", reset_email="noreply@nohost.com", active="active") to rec = RequestRecord(id="manager", reset_email="noreply@nohost.com", active="inactive"),

The asset statement would the check that the manager's activate status did not change. But the test failed because there is nothing from what I could see in the code to keeps you from doing that programmatically. The users overviews page is where we make it so they can't manually update a manager. And there are test for that and for checking that the cron job doesn't do it either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants